Error handling about google-maps-services-go HOT 7 CLOSED

Please feel free to sketch out an initial implementation of how errors should be propagated. I'll happily take input on how to improve this library.

/cc @samthor who has a lot more knowledge of how Go code should be written than I.

from google-maps-services-go.

There's two approaches I suppose. Either define different Err... objects that are returned, e.g. ErrOverQueryLimit, or add helper methods:

  if maps.IsOverQueryError(returnedErr) {
    ..
  }

from google-maps-services-go.

@ebati have you made any progress on this issue?

I too would be interested in a more consistent error handling.
For instance, the Places API implementation still treats ZERO_RESULTS as an error.

I was personally thinking that ZERO_RESULTS should not return an error but an empty response (per the API docs: ZERO_RESULTS indicates that the search was successful but returned no results).
It would be nice to be able to differentiate between the other errors without having to compare the error string!

I could take a stab at it if it helps.

from google-maps-services-go.

Since we moved to a different provider, i didnt use this library so i couldnt make time to work on this. I should have noted here. Sorry for that😓

from google-maps-services-go.

@peergynt it would be great if you could send a PR with a consistent ZERO_RESULTS handling approach.
It'd help us a lot.

Thx!

from google-maps-services-go.

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

from google-maps-services-go.

Closing this. Please reopen if you believe it should be addressed. Thank you for your contribution.

from google-maps-services-go.