Comments (5)
You are going to laugh. I literally JUST hit this issue writing the compression filter.
Looks like I'm implementing a fix!
from quilkin.
Agreed, they should probably be something more like:
"contents" => from_utf8(packet).unwrap.or_else(|| format!("<raw bytes. len: {}>", packet.len()))
- or something like that
from quilkin.
I'm thinking it makes more sense to remove the log lines rather than work around it? Currently it seems to be unneeded work to try to parse every packet and create a log record each time only to discard it, especially since metrics tracks that info already.
from quilkin.
I honestly find it really useful when debugging issues found by integration tests, because I can see where in the flow packets are failing.
from quilkin.
I think this relates to #153 outcome in that since the log messages are only needed during development we can compile them entirely away? I'm thinking then we can log them at level trace
so that they are explicitly enabled, temporarily when needed
from quilkin.
Related Issues (20)
- Quilkin not proxying on IPv4 HOT 7
- Add configuration to modify downstream channel size
- Fix Last Agones Test From Refactor HOT 1
- Phoenix HTTP service stops responding after some amount of time
- QCMP pings seem to be returning the wrong information.
- Stream metrics don't seem always reliable
- Datacenter map doesn't seem to be kept up to date in proxies
- Improve deserialisation errors in the Kubernetes provider
- Add support for `--address-type` option to Agones agent HOT 4
- Investigate eBPF Support
- Proxy doesn't remember which IP address it received on when sending packets back to the client HOT 9
- Gameserver events are failing due parsing errors
- Unit tests intermittently fails HOT 1
- `EndpointAddress` should be resolved once HOT 2
- Make filters static dispatch? HOT 3
- io_uring threads can get into high CPU condition HOT 3
- Agent's Kubernetes provider should not depend on ConfigMap
- Proxy Static Configuration defaults to an empty HashMap when using HashedTokenRouter filter HOT 1
- First connection to newly allocated gameserver using Proxy Dynamic Configuration with HashedTokenRouter filter is flaky
- Changes To The ConfigMap in the Relay aren't being picked up by proxies HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quilkin.