hi! Thank you for this wonderful product, it looks very promising! A small questio

Hey. <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url

hmmmm.. with -vdebug flag I found these lines <di

Hi, <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

Created <a class="issue-link js-issue-link" data-error-text="Failed to load title" dat

Use file sync only ,about googlecontainertools/skaffold

ericzzzzzzz commented on June 8, 2024 1

It seems that the sync failing for your case is due to the image mismatch between the built image and the container image in remote pods or pods are not running.

skaffold/pkg/skaffold/sync/sync.go

Lines 339 to 363 in 88e1c17

    
           for _, ns := range namespaces { 
        
           	pods, err := client.CoreV1().Pods(ns).List(ctx, metav1.ListOptions{}) 
        
           	if err != nil { 
        
           		return fmt.Errorf("getting pods for namespace %q: %w", ns, err) 
        
           	} 
        
           	for _, p := range pods.Items { 
        
           		if p.Status.Phase != v1.PodRunning { 
        
           			continue 
        
           		} 
        
           		for _, c := range p.Spec.Containers { 
        
           			if c.Image != image { 
        
           				continue 
        
           			} 
        
           			cmd := cmdFn(ctx, p, c, files) 
        
           			errs.Go(func() error { 
        
           				_, err := util.RunCmdOut(ctx, cmd) 
        
           				return err 
        
           			}) 
        
           			numSynced++ 
        
           		} 
        
           	} 
        
           }

Sure I'll create another issue to add log to make debug easier

from skaffold.

hitstill commented on June 8, 2024 1

Hey. @ericzzzzzzz
It seems your assumption was correct.
I added an extra line to my sync.go

				if c.Image != image {
					log.Entry(ctx).Warnf("c.Image = %s, image = %s", c.Image, image)
					continue
				}

Issued make and and see what I got in console (among other things)
WARN[0029] c.Image = dev:5000/symfony, image = dev:5000/symfony:latest@sha256:90efe8c14f641d63167a528df9257dead81860987ce85256df8b58638987be1d subtask=-1 task=DevLoop

Obviously those value aren't equal. Replacing (not) equality check with !strings.HasPrefix() fixed the problem for me. Not sure though fixing the symptom is the right thing to do here

from skaffold.

izemlyanskiy commented on June 8, 2024

hmmmm.. with -vdebug flag I found these lines


WARN[0074] sync failed for artifact "my-image:0.1.9-01c818c@sha256:ec687110b5af7458c733a746035654fe9f95c3d15856a9e924212502de472a66"  subtask=-1 task=DevLoop
WARN[0074] Skipping deploy due to sync error:copying files: didn't sync any files: sync failed for artifact "my-image:0.1.9-01c818c@sha256:ec687110b5af7458c733a746035654fe9f95c3d15856a9e924212502de472a66"  subtask=-1 task=DevLoop

is there a way to find out why "sync failed"?
thanks

from skaffold.

ericzzzzzzz commented on June 8, 2024

Hi, @izemlyanskiy There are the limitations about file-sync https://skaffold.dev/docs/filesync/#limitations that may cause it fail, could you provide a minimal reproducible project to help us get a better understanding of this issue ? Thanks

from skaffold.

izemlyanskiy commented on June 8, 2024

hey @ericzzzzzzz
thank you for the response. I'll try to compile one, but meanwhile, is there a way to debug it on my end?
I mean, you mentioned about the limitations, is there a way to find out which limitation we met exactly?
I have a theory, it might be because we don't use the root user inside our containers, will try later this week.

May I ask you to add more logging so users like me are able to dig around themselves before bothering you with an issue like this one?

from skaffold.

ericzzzzzzz commented on June 8, 2024

Created #9200

from skaffold.

Use file sync only about skaffold HOT 6 OPEN

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	for _, ns := range namespaces {
	pods, err := client.CoreV1().Pods(ns).List(ctx, metav1.ListOptions{})
	if err != nil {
	return fmt.Errorf("getting pods for namespace %q: %w", ns, err)
	}

	for _, p := range pods.Items {
	if p.Status.Phase != v1.PodRunning {
	continue
	}

	for _, c := range p.Spec.Containers {
	if c.Image != image {
	continue
	}

	cmd := cmdFn(ctx, p, c, files)
	errs.Go(func() error {
	_, err := util.RunCmdOut(ctx, cmd)
	return err
	})
	numSynced++
	}
	}
	}