Code Monkey home page Code Monkey logo

Comments (5)

chanseokoh avatar chanseokoh commented on July 17, 2024 1

@mpeddada1 this I believe was introduced in 3.4.3 and looks to be an important regression issue to fix before making the next release.

from jib.

beskow avatar beskow commented on July 17, 2024

We are facing the same problem when upgrading to jib-maven-plugin 3.4.3.

It seems to be a Windows-only problem (it works correctly when running the command in WSL2/Ubuntu)

Staying on 3.4.2 for now.

from jib.

bamanuel1 avatar bamanuel1 commented on July 17, 2024

Breaking change is addition of the following line.

DockerInfoDetails dockerInfoDetails = dockerClient.info();

This line blocks until docker info -f "{{json .}}" process exits to start reading the inputStream. On windows, it only exits after inputStream is read, resulting in deadlock.

Can be reproduced on windows with following code. Only occurs with -f option.

Process process = new ProcessBuilder("docker", "info", "-f", "json").start();
process.waitFor();

from jib.

mpeddada1 avatar mpeddada1 commented on July 17, 2024

@chanseokoh Assigned this to myself.
@beskow My initial hypothesis was that this may have been caused due to some unconventional log warnings we added but this is really helpful information (#4267 (comment))

This line blocks until docker info -f "{{json .}}" process exits to start reading the inputStream. On windows, it only exits after inputStream is read, resulting in deadlock.

from jib.

Chris-Frendo avatar Chris-Frendo commented on July 17, 2024

We encountered this issue as well. Seems to be working on linux but hanging on windows.

Doing a breakpoint on line 191 in CliDockerClient and calling waitFor() hangs on windows. If you call getInputStream() without calling waitFor() before it, it works as expected.

Downgraded to 3.4.2 in the meantime.

from jib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.