Code Monkey home page Code Monkey logo

Comments (10)

demobox avatar demobox commented on August 14, 2024

Thanks for putting this together though, as someone who's started setting up spinnaker a few times for greenfields and then decided I couldn't be bothered, this repo and all the doco is incredibly helpful

Glad to hear, thanks!

I just tested the link by pasting it into a browser and it works for me - is the error reproducible for you?

/cc @dorbin

from spinnaker-for-gcp.

afirth avatar afirth commented on August 14, 2024

yup, can repro. Pasting the link works fine. Clicking it from the GKE -> Applications sidebar doesn't. Refreshing the page then fixes it. Opening the link in a new tab also works fine. I opened the issue because I figured it probably affected more than just this one use case, but it seems isolated to the cloudshell link

from spinnaker-for-gcp.

demobox avatar demobox commented on August 14, 2024

yup, can repro. Pasting the link works fine. Clicking it from the GKE -> Applications sidebar doesn't.

Thanks for confirming! I had tried pasting straight into a browser window; will from the Applications page.

/cc @duftler

from spinnaker-for-gcp.

demobox avatar demobox commented on August 14, 2024

Clicking it from the GKE -> Applications sidebar doesn't

Just to clarify: do you mean this link?

image

I clicked on that and it seemed to work for me:

image

from spinnaker-for-gcp.

afirth avatar afirth commented on August 14, 2024

correct. reproducible for me in a fresh install of firefox too. Only thing I see 404ing is:

VM540:1 GET https://cloudusersettings-pa.clients6.google.com/v1alpha1/settings/SIDENAV_COMPACT_MODE?key=AIz[redacted]741g 404

which happens in both firefox and chrome.

Element is

<a href="https://console.cloud.google.com/cloudshell/editor?shellonly=true&amp;cloudshell_git_repo=https://github.com/GoogleCloudPlatform/spinnaker-for-gcp.git&amp;cloudshell_working_dir=scripts/manage&amp;cloudshell_tutorial=landing_page_expanded.md&amp;cloudshell_print=instructions.txt">Open management console in Cloud Shell</a>

It only happens if I don't open in a new tab.

from spinnaker-for-gcp.

demobox avatar demobox commented on August 14, 2024

reproducible for me in a fresh install of firefox too

Hrm, interesting - so clicking the link to open in a new tab works, but allowing it to open in the same tab reproducibly fails?

Thanks for the additional details!

from spinnaker-for-gcp.

afirth avatar afirth commented on August 14, 2024

Exactly. Which is weird and probably not a productive use of anyone's time to fix, but still broken.

from spinnaker-for-gcp.

enricojonas avatar enricojonas commented on August 14, 2024

Same happening for me. Maybe something wrong with the session in this state when opening link in same tab? Running Chrome 77.0.3865.120

Traffic log:

image

Edit: just updated, but same result with Version 78.0.3904.70

from spinnaker-for-gcp.

demobox avatar demobox commented on August 14, 2024

Exactly. Which is weird and probably not a productive use of anyone's time to fix, but still broken.

Does seem weird, indeed. Curious to see if anyone else runs into this too. Thanks for the additional details!

from spinnaker-for-gcp.

demobox avatar demobox commented on August 14, 2024

I've passed this on to the UI team and they've said they'll look into it. Closing for now.

from spinnaker-for-gcp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.