Comments (3)
I think we should still do this -- reseting SLO.
from point-of-sale.
Update since this is near out-of-SLO:
- I closed a similar bug #92 because adding granular unit tests is not something our team can afford to do.
- However, judging from the description of this GitHub issue (#94), it sounds like this issue is about testing the frontend after it has been fully deployed — not unit testing the frontend with all its dependencies either mocked or disconnected.
- That would be a useful test, but "unit test" might not be the appropriate term.
- I have updated the name of this GitHub issue ("Add unit tests for the frontend" → "Test CI/CD deployments via requests to frontend"), and description.
- @Shabirmean correct me if I'm wrong, but I think adding such tests would involve:
- adding a step inside some of the Cloud Build configs (e.g., pos-pr-open-to-main.yaml) that either makes raw
curl
HTTP requests or uses a tool like Cypress — similar to Bank of Anthos — to test various user journeys (e.g., add a BigBurger to cart, check out, and read the bill/receipt).
- adding a step inside some of the Cloud Build configs (e.g., pos-pr-open-to-main.yaml) that either makes raw
from point-of-sale.
@NimJay - Thank you once again for triaging these issues. Yes, I think it makes sense to focus on e2e like tests to ensure the App experience works as expected. Also, I agree with the description you have provided in terms of what such a test would look like.
from point-of-sale.
Related Issues (20)
- Move away from using Personal Access Token for CI HOT 2
- Action Required: Fix Renovate Configuration
- Update the MySQL driver reference HOT 1
- Check if affected by CVE-2022-22965
- Add `securitContext` in the default `Deployments`
- Upgrade from Java 11? HOT 5
- Move the container base images to `temurin-jre`?
- Security Policy violation Binary Artifacts HOT 25
- cleanup: use secrets manager instead of encrypted secrets for GH tokens HOT 1
- cleanup: merge the jss branch into main
- traces for api-server not captured
- Add GitHub bot to check Apache license headers, on pull-requests
- Dependency Dashboard HOT 5
- `skaffold build|run` fails in Cloud Shell with `api-server` HOT 3
- Add unit tests for the inventory service HOT 2
- Add unit tests for the payments service HOT 3
- Add unit tests for the apiserver service HOT 2
- Remove the kubernetes-manifests directory
- Check if "Optimizing Java apps tips" are in place HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from point-of-sale.