docs: tag_filter_any does not mention it will also match images without tags about gcr-cleaner HOT 3 CLOSED

Yea, it matches untagged images too.

from gcr-cleaner.

Which is good! Except, the keep logic includes the untagged images as well. I think this is undesired behavior.
If I have images tagged like so:
<>
<1.0.8>
<1.0.7>
<1.0.6>
<1.0.5>
<>
Where <> are untagged images.
Then if I run a filter like so:
-tag-filter-any "^(\d+).(\d+).(\d+)$" -keep 3

I would expect it to delete the untagged images and image 1.0.5, keeping 1.0.8, 1.0.7, and 1.0.6. But this is not the case. It will delete 1.0.6, 1.0.5, and the untagged image after 1.0.5. This is not very glamorous but I think a solution that would fix this without a bunch of refactoring would be to change this line in pkg/gcrcleaner/cleaner.go:
if keepCount < keep { to if keepCount < keep && len(m.Tags) != 0 {

Let me know if you'd like this change and I can whip up a PR.

from gcr-cleaner.

I think the core of the issue is:

the keep logic includes the untagged images as well...

And what the right behavior is here. In my head, "keep" means keep N things, not keep N tagged things but delete everything else.

from gcr-cleaner.