Code Monkey home page Code Monkey logo

Comments (5)

enocom avatar enocom commented on August 23, 2024

I think that's reasonable. One thing to consider is attaching fingerprints to the assets, such that changes immediate reach our uses. To me that implies introducing a better build tool for the frontend.

cc @saranshdhingra who's been thinking about this problem as well.

from gcping.

yuryu avatar yuryu commented on August 23, 2024

Sorry I opened the PR before reading your comment. At the moment there is no CDN or cache control so I'm assuming it's safe, but yes, I'm also interested in introducing a build tool and potentially a framework too.

from gcping.

saranshdhingra avatar saranshdhingra commented on August 23, 2024

The 2 branches which are ahead of the main branch( one of them being https://github.com/GoogleCloudPlatform/gcping/tree/ui-with-maps-design-2) have this problem solved.

They aren't merged because we are experimenting with the UX a bit before changing the design for the users.
So, the change will essentially be nullified once we merge the other branch(in fact if I am not wrong it will lead to conflicts on the index file).

So, my suggestion is we close this, Sorry for the effort you put in :(

from gcping.

enocom avatar enocom commented on August 23, 2024

@saranshdhingra Could we try to merge some of these improvements one at a time separately from the UX changes? Otherwise, the UX changes will be blocking any changes to the frontend.

from gcping.

yuryu avatar yuryu commented on August 23, 2024

I'll go ahead and merge this as it won't change behaviors and the existing work can continue independently.

from gcping.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.