no longer works on Cloud Run on GKE about cloud-run-hello HOT 5 CLOSED

My suspicion is that our Region detection causes this.
On a VM, this returns 404:

curl -H "metadata-flavor: Google" http://metadata.google.internal/computeMetadata/v1/instance/region

as there's /zone on VMs.

from cloud-run-hello.

I'm not sure why it worked before though, but looking at the code it must be something related to metadata. I will investigate further later tonight and report back.

from cloud-run-hello.

I mean my comment alone explains at least why it doesn't work. Other variables that trigger this situation seem like they work fine on a VM environment.

from cloud-run-hello.

Yeah you were spot on. I verified by doing another test this time with GKE_METADATA and workload identity enabled. These commands were run from the application pod:

/ # wget --header "metadata-flavor: Google" http://metadata.google.internal/computeMetadata/v1/instance/region
Connecting to metadata.google.internal (169.254.169.254:80)
wget: server returned error: HTTP/1.1 404 Not Found
/ # wget --header "metadata-flavor: Google" http://metadata.google.internal/computeMetadata/v1/instance/zone
Connecting to metadata.google.internal (169.254.169.254:80)
saving to 'zone'
zone                 100% |************************************************************************************************|    41  0:00:00 ETA
'zone' saved

I'm going to try create a quick fork that doesn't get the region and see if the rest still works as is. Thanks so much for the pointers saved me a lot of time debuggin this.

from cloud-run-hello.

This samos123/cloud-run-hello@5584ed7 fixed the issue for Cloud Run on GKE as hacky workaround. I will provide a cleaner fix and submit PR later this week.

from cloud-run-hello.