Code Monkey home page Code Monkey logo

Comments (5)

ahmetb avatar ahmetb commented on June 8, 2024

What if we brought the cloudbuild support back? That would eliminate the need for this.

Otherwise a more extensible design would be preferable that allows us plugging in cmd, docker, cloudbuild.

from cloud-run-button.

jamesward avatar jamesward commented on June 8, 2024

Yeah, I like that better than adding yet another way to run the build. For reference, the feature request for Cloud Build support is: #14

from cloud-run-button.

ahmetb avatar ahmetb commented on June 8, 2024

Honestly I feel like this request is valid, because I can see people would do non-trivial multi-step builds.

That's where arbitrary commands like Jib or ko can help, but granted, we need to bring them to the build environment by pre-installing.

from cloud-run-button.

jamesward avatar jamesward commented on June 8, 2024

Are you saying we should do something like above in addition to Cloud Build support?

from cloud-run-button.

jamesward avatar jamesward commented on June 8, 2024

I'm thinking about adding this since we've already figured out how to add / run scripts. So we could allow a custom build via:

    "hooks": {
        "build": {
            "commands": [
                "./foo.sh"
            ]
        }
    }

This would take precedence over Dockerfile, Maven Jib, and Buildpacks. Adding a 4th way to build isn't ideal, but I continue to run across places where my build produces the container image and there isn't another good way to handle this (except maybe Cloud Build support).

from cloud-run-button.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.