Comments (6)
The primary reason it behaves this way is that I had a vision (not implemented) that you could signal the berglas process and it would re-process the secrets (to check for updates) and re-spawn the process if values had changed. I'm not opposed to switching to exec, except I think it doesn't work on Windows?
from berglas.
Hi @sethvargo - I imagine you're right. I wonder however if working on windows should be a goal of this command. Basically I wonder if there should be different commands for the two different platforms.
berglas exec
berglas win-exec
For example, the origin of all this is signal handling but from everything I see signals are not really a windows thing:
- Windows is not POSIX. It does not have signals.
- "Signals are primarily used on Unix-like systems." - golang docs around os.Signal
- ... the internet goes on ...
Maybe that's a hint that exec on windows/unix should be allowed to be different? In my own work I've leaned on unix exec
so that I don't have to get into things like signal handling. But honestly I haven't had to design anything cross-platform and I don't know good patterns for it.
from berglas.
I'll look into it.
from berglas.
Let me know if that works for you ^
from berglas.
I built this, deployed it, and have been watching it all day. It seems fine -- the process is still working. Secrets appear to be set as before and as expected there are no more error messages around signals.
Thanks for the quick turnaround! I look forward to seeing this in a future release. Also fwiw I think your design around berglas refs is excellent. Being able to treat secrets like configs has been very helpful. Both our devs and SREs appreciate how visible everything is now.
from berglas.
This issue has been automatically locked since there has not been any
recent activity after it was closed. Please open a new issue for
related bugs.
from berglas.
Related Issues (20)
- Downloaded binary is sometimes broken. HOT 6
- berglas: cannot execute binary file: Exec format error HOT 1
- Checksum in sum.golang.org is different from download without proxy/checksum database (GOPRIVATE=*) HOT 7
- Unable to use the mutation webhook method with kubernetes 1.21.5 and admissionregistration.k8s.io/v1 on GKE HOT 11
- Download berglas seems to be broken with exec format error: HOT 1
- Berglas interacts badly with tools that rely on process wrapping like Argo-workflows HOT 3
- About the latest release HOT 2
- 1.0.0 image breaks kubernetes integration HOT 6
- New version not published to https://storage.googleapis.com/berglas HOT 1
- using secret account credentials.json instead of workflow identity HOT 1
- CrashLoopBackOff when setting command in my deployments HOT 2
- version only shows as "source" if i go install HOT 3
- I would like a new release. HOT 1
- Setting KMS key location for golang library
- Mutating webhook does not run if secrets are only set through a configMap HOT 1
- Multiple CVEs in docker image HOT 4
- Please provide new release with newest go version HOT 3
- Support rich JSON secrets
- invalid value "fatal" for log level: no such level "fatal"
- Mutating Webhook setup for K8S is missing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from berglas.