Comments (2)
rmacklin
commented on May 18, 2024
@jeffposnick This change also changed the output from KB (1024 bytes) to kB (1000 bytes), which is inconsistent with how Chrome's network tab displays file sizes (as well as how ls usually displays file sizes). Since Chrome displays the size in KB, I think having the tool output sizes in kB can be confusing. I can understand generally wanting to use npm packages instead of hand-rolled functions, but in this case the function was pretty simple and I think replacing it with pretty-bytes was actually a downgrade due to the KB/kB mismatch.
Is there any chance you'd be open to a PR reverting f201914, or is that outside the scope of maintenance for this repository (given that it's kind of deprecated by workbox)?
from sw-precache.
jeffposnick
commented on May 18, 2024
I don't believe that this is something we'd change at this point in sw-precache's lifespan.
from sw-precache.
Related Issues (20)
- sw-precache don't work with css HOT 1
- Where is the precache option such as in the toolbox precache method
- This is my code and I its not working
- [Question] Production Cache Issue
- skipWaiting false and a refresh button HOT 2
- runtimeCaching with client side routing with javascript and html
- SW precaching static assets delaying onload? HOT 4
- service worker request many resources.And when user fetch something, this request is blocked
- Give more abstraction to the filesystem
- Cache Fetch fails on iOS HOT 1
- service worker CORS opaque response error HOT 2
- RuntimeCaching is not working when handleFetch is set to false.
- Serve cached resource and then update in background HOT 1
- sw-precache freezes on vueJS build HOT 1
- Generated service worker doesn't claimClient or skipWaiting on Chrome 71 incognito
- RuntimeCaching is not working with Protractor & Selenium automated test.
- workbox is not defined (window 10) HOT 1
- Vulnerability in lodash.template dependency HOT 1
- Extension only works once after installing or re-installing
- Failed to compile
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sw-precache.