bug: this keyword in constructSubtreeForNode makes error about dom2html HOT 4 CLOSED

Hey @TroyTae - thank you so much for your contribution and welcome to the project!

I would suggest to use the module as a whole when testing it, like this:

const subtree = require('./subtree');

test("shadow root", () => {
  const nodeName = "DIV";
  const subTree = constructSubtreeForNode(document, {
    nodeType: NODE_TYPES.ELEMENT_NODE,
    nodeName: nodeName,
    children: [createElemForNode(document, 'all', {
      nodeType: NODE_TYPES.ELEMENT_NODE,
      nodeName: nodeName
    })],
    shadowRoots: [createElemForNode(document, 'all', {
      nodeType: NODE_TYPES.ELEMENT_NODE,
      nodeName: nodeName
    })]
  });
});

from dom2html.

I think that solves the problem, should I be wrong, please reopen the issue and let me know :)

from dom2html.

Yes of course the code can fix problem.
I’m just worried about guide to not use object split to developer.
But maybe it’s fine because this is experimental project yet :)

from dom2html.

I understand that point, but subtree is an internal part of dom2html and is neither documented nor should it be used, normally. The usual entrypoint is serialize.

from dom2html.