Comments (5)
tomayac
commented on August 12, 2024
1
I'm sorry, I see the problem now. While the label is always there, some toggle styles means they are empty, requiring an ARIA label. I completely missed this, apologies again. Re-opening the Issue, and hoping to release a fix later this week.
from dark-mode-toggle.
tomayac
commented on August 12, 2024
1
Thanks both, @Sungodragon and @aress31! This has now been fixed for good via c5a79ae. I have just released v0.9.0 that includes this fix.
from dark-mode-toggle.
tomayac
commented on August 12, 2024
I think this is a different input#t (the toggle's IDs can re-appear on the page due to the toggle using shadow DOM), since as you can see from your screenshot the input from the toggle does have an associated label.
I also ran Lighthouse on other pages that include the toggle, and everything was fine. I can't see the URL of the page you tested with, but try checking if the page uses input#t somewhere.
from dark-mode-toggle.
Sungodragon
commented on August 12, 2024
This issue is present on https://googlechromelabs.github.io/dark-mode-toggle/demo/index.html
Kindly check from Chrome Lighthouse
from dark-mode-toggle.
Sungodragon
commented on August 12, 2024
I have Fixed the issue with aria-label="Toggle Theme" by adding it here, FYI I am a Junior Dev so I was just fiddling with these things. I have used the Source un minified HTML here.
from dark-mode-toggle.
Related Issues (20)
- [Feature Request] Set SVG icons HOT 1
- Unable to Load png files when running on Github Pages HOT 2
- Apart from `light` and `dark`, add a `system` option HOT 9
- Dead GitHub Pages HOT 1
- Any way to toggle light/dark native widgets when using <meta name='color-scheme' content='light dark'> ? HOT 3
- dark-mode-toggle with React HOT 10
- Dark mode website HOT 5
- "Permanent" property seems to have stopped working HOT 5
- Implement saving light/dark mode HOT 8
- Dark mode doesn't work HOT 5
- Keep light mode after changing page for Wordpress Theme HOT 3
- Accessibility error HOT 2
- Consider aria-label="auto" aria-live="polite" HOT 1
- Reloading in the demo in dark mode still causes an initial flash of the light theme. HOT 8
- Problems styling ::parts and pseudo elements such as ::before HOT 15
- [feature request] support SRI (sub resources integrity) HOT 6
- [feature request] support Bootstrap 5.3 color modes HOT 3
- Support for using as a React component HOT 2
- Add support for declarative shadow DOM
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dark-mode-toggle.