Comments (6)
+1 to this, I am using auto prefixer to add vendor prefixes which is causing similar problems - in my case it's Error: Unknown pseudo-class selector ":-webkit-input-placeholder"
.
from critters.
We'll have to manually strip unknown pseudo's.
from critters.
Should be fixed in 1.2.0.
from critters.
It was not fixed. I'm using v1.2.1.
1 rules skipped due to selector errors:
.el-input:horizontal -> unknown pseudo-class selector ':horizontal'
Critters: inlined 2.67 kB (3% of original 80.3 kB) of css/chunk-vendors.0bb8d6eb.css.
2 rules skipped due to selector errors:
.profile-wrapper:vertical -> unknown pseudo-class selector ':vertical'
-> '' is not a valid selector
Critters: inlined 5 kB (4% of original 101 kB) of css/app.215d550f.css.
Critters: inlined 458 B (101% of original 452 B) of inline CSS.
PS: 101% 😂
from critters.
@koresar - if you're still able to, I'd love to know if 2.x fixed it for you!
from critters.
Just tried v2. Discovered another bug.
Here is what I did on my standard VUE CLI 3 project:
$ npm i -S critters-webpack-plugin@latest
+ [email protected]
And then:
$ npm run build
> vue-cli-service build
⠙ Building for production...1 rules skipped due to selector errors:
.el-input::-webkit-scrollbar -> unknown pseudo-class selector '::-webkit-scrollbar'
3 rules skipped due to selector errors:
.profile-wrapper::-webkit-scrollbar -> unknown pseudo-class selector '::-webkit-scrollbar'
a[data-v-23f15c82]:-webkit-any-link -> unknown pseudo-class selector ':-webkit-any-link'
a[data-v-23f15c82]:-webkit-any-link -> unknown pseudo-class selector ':-webkit-any-link'
Critters: inlined 664 B (0% of original 100 kB) of css/app.723135db.css, reducing non-inlined size 57% to 57.8 kB.
⠹ Building for production...
ERROR Failed to compile with 1 errors 10:33:28
TypeError: Cannot read property 'trim' of undefined
- critters.js:417
[flash-webapp]/[critters-webpack-plugin]/dist/critters.js:417:53
- critters.js:42
[flash-webapp]/[critters-webpack-plugin]/dist/critters.js:42:13
- critters.js:57
[flash-webapp]/[critters-webpack-plugin]/dist/critters.js:57:16
- Array.filter
...
Here is my webpack config:
const Critters = require("critters-webpack-plugin");
config.plugins.push(
new Critters({
fonts: false
})
);
I have no idea what's going on. But [email protected]
was working perfectly fine.
Should I open a new issue for this?
from critters.
Related Issues (20)
- Branching webpack versions
- `pruneSource: true` not pruning files
- Non-critical rules are erased from inline styles HOT 6
- Local font source is not recognized as valid
- relative urls within css
- Allow attributes to be set on generated style tag for CSP
- How to use critters in next.js v13 HOT 2
- critters de-encodes html entities HOT 1
- Parse include/exclude markers with @preserve or /*! hints
- Cannot read properties of undefined (reading 'setAttribute') HOT 6
- Disable font-face exclusion
- The `allowRules` option is missing in the types and documentation
- Passing includeSelectors config HOT 2
- Add the option of a prefix path
- Used css attribute selector gets removed by critters
- Feature Request: Expose method `processCss` which returns inlined css only
- Simple Example fails
- Building Angular 17.1 with Angular CLI when using Bootstrap 5.3.2 results in Critical CSS Inlining failing because 2 rules are skipped due to selector errors HOT 9
- 2 different lock files
- The css modules key styles are not inlined when configuring generateScopedName. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from critters.