Transfer handlers broke after upgrading to v4 about comlink HOT 4 CLOSED

After digging into this a little bit, I don’t think I will fix this from Comlink’s side.

The biggest change from v3 to v4 was to remove object traversals that were pretty costly, especially on low-end phones. To fix this, I’d have to either re-introduce traversals or give some special handling to apply (and maybe even call). A quick prototype for that showed that this requires a good amount of code for something that I think is a rather niché problem.

That being said, you can work around this by giving your transfer handle the capability to traverse objects:

Comlink.transferHandlers.set("ERROR",  {
  canHandle (obj) {
      if(Array.isArray(obj)) {
        return obj.some(el => this.canHandle(el));
      }
      return obj instanceof Error
  },
  serialize (obj) {
      if(Array.isArray(obj)) {
        return [obj.map(el => this.serialize(el)), []];
      }
      const message = obj && obj.message
      const stack = obj && obj.stack
      obj = Object.assign({}, obj, { message, stack })
      return [obj, []]
  },
  deserialize (obj) {
      if(Array.isArray(obj)) {
        return obj.map(el => this.deserialize(el));
      }

      return Object.assign(Error(), obj)
  }
});

(Demo & Code: https://comlink-issue-284.glitch.me/)

I’m closing this, but please re-open if you disagree with my decision/reasoning :)

from comlink.

Hm, I might be able to fix that on Comlink’s side.

Can you give me a minimal setup in a gist or something that reproduces this bug? Then I can turn it into a test.

from comlink.

Here: http://next.plnkr.co/edit/jKM1kjMrb43XdbWM

Check the console for errors.

from comlink.

Looking at this now

from comlink.