[v4] comlink.d.ts(14,26): error TS2307: Cannot find module './protocol.js'. about comlink HOT 7 CLOSED

Yeah, this is a long-standing issue with TypeScript, but this problem already existed with Comlink v3.

FWIW, whenever you use bundlers like Rollup you don’t get these errors.

casting as any is the only solution in this case...

Not true :D That is the reason why I set self to be the default value for expose(), so this will compile just fine:

expose(Markdown);

from comlink.

Good catch, @lacolaco! Thanks for flagging that.

I pushed 4.0.0-alpha.8 which should fix that issue. Can you please confirm?

from comlink.

@surma the original problem seems solved. thank you!
And now I'm in another situation. it looks a breaking change in typing.

ERROR in src/app/worker/markdown.ts(18,18): error TS2345: Argument of type 'Window' is not assignable to parameter of type 'Endpoint'.
  Types of property 'postMessage' are incompatible.
    Type '(message: any, targetOrigin: string, transfer?: Transferable[]) => void' is not assignable to type '(message: any, transfer?: any[]) => void'.
      Types of parameters 'targetOrigin' and 'transfer' are incompatible.
        Type 'any[]' is not assignable to type 'string'.

import * as marked from 'marked';
import { expose } from 'comlink';

export class Markdown {
  compile(source: string) {
    return new Promise<string>((resolve, reject) => {
      marked(source, (err, result) => {
        if (err) {
          reject(err);
          return;
        }
        resolve(result);
      });
    });
  }
}

expose(Markdown, self); // <---- self is not compatible to Endpoint

I think this is not by design, right?

from comlink.

Comlink v4 has loads of breaking changes :D

Before I start: expose() passes self by default now.

But this looks more like TypeScript isn’t aware that you are in a worker context. A simple

declare var self: DedicatedWorkerGlobalScope;

should force TypeScript to assume a worker context.

HTH

from comlink.

It's not easy to solve.

• DedicatedWorkerGlobalScope is declared in webworker lib.
• self is declared in both of dom and webworker
  • so, dom and webworker are incompatible

declare var self: DedicatedWorkerGlobalScope;

This line is not valid in dom context because DedicatedWorkerGlobalScope is only in webworker context and Window and DedicatedWorkerGlobalScope is not compatible. It's exclusive.

So, if Comlink is used within usual frontend projects, this restriction requires developers to separate tsconfig.json and change transpilation workflow.

from comlink.

casting as any is the only solution in this case...

expose(Markdown, self as any);

from comlink.

@surma I didn't know about the default value! It's perfect for me. Thank you!

The original issue is solved. I close here.

from comlink.