Code Monkey home page Code Monkey logo

Comments (6)

OrKoN avatar OrKoN commented on August 15, 2024 1

@sadym-chromium #2275 (comment)

from chromium-bidi.

OrKoN avatar OrKoN commented on August 15, 2024

This causes the test in Puppeteer "navigation Page.waitForNavigation should work when subframe issues window.stop()" to fail.

from chromium-bidi.

OrKoN avatar OrKoN commented on August 15, 2024

cc @sadym-chromium

from chromium-bidi.

sadym-chromium avatar sadym-chromium commented on August 15, 2024

Cannot reproduce with Mapper:

@pytest.mark.asyncio
async def test_nestedBrowsingContext_evaluateRightAfterCreating_evaluates(
        websocket, context_id, html, iframe):
    # https://github.com/GoogleChromeLabs/chromium-bidi/issues/2275

    await subscribe(websocket, ["browsingContext.contextCreated"])
    # Init navigation to a page with an iframe.
    await goto_url(websocket, context_id, html(iframe("about:blank")), "none")

    iframe_context_created_event = await wait_for_event(websocket,
                                          "browsingContext.contextCreated")

    await execute_command(
        websocket, {
            "method": "script.evaluate",
            "params": {
                "expression": "1",
                "awaitPromise": False,
                "target": {
                    "context": iframe_context_created_event["params"]["context"],
                }
            }
        })

from chromium-bidi.

sadym-chromium avatar sadym-chromium commented on August 15, 2024

Is there a Puppeteer test for this?

from chromium-bidi.

OrKoN avatar OrKoN commented on August 15, 2024

fixed via #2294

from chromium-bidi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.