Code Monkey home page Code Monkey logo

Comments (7)

mathiasbynens avatar mathiasbynens commented on June 23, 2024

This is blocking #110: the Firefox implementation strictly follows the spec, and requires a session to be created before accepting any non-static commands.

from chromium-bidi.

mathiasbynens avatar mathiasbynens commented on June 23, 2024

Also likely blocking #121.

from chromium-bidi.

sadym-chromium avatar sadym-chromium commented on June 23, 2024

As the session should be implemented by the embedder, our NodeJS server simply accepts all the session commands:

if (request.url.startsWith('/session')) {

from chromium-bidi.

OrKoN avatar OrKoN commented on June 23, 2024

We need this for Puppeteer. Firefox impl supports it and it's part of the spec.

from chromium-bidi.

sadym-chromium avatar sadym-chromium commented on June 23, 2024

The best the mapper can do is to send a error "500 | session not created", as the session is already exists at the point mapper is created. And the transport implementation (bidiServerRunner) should implement the proper request handling.

from chromium-bidi.

sadym-chromium avatar sadym-chromium commented on June 23, 2024

Closing, as session handling cannot be handled by the Mapper.

from chromium-bidi.

OrKoN avatar OrKoN commented on June 23, 2024

Re-opening this based on the latest understanding that mapper should support multiple sessions and that it should provide handling for capabilities implementable via CDP such as ignoreHTTPSErrors. This capability requires calling Security.setIgnoreCertificateErrors on every target as there is no other way to implement it in Chrome.

from chromium-bidi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.