Comments (7)
This is blocking #110: the Firefox implementation strictly follows the spec, and requires a session to be created before accepting any non-static commands.
from chromium-bidi.
Also likely blocking #121.
from chromium-bidi.
As the session
should be implemented by the embedder, our NodeJS server simply accepts all the session commands:
chromium-bidi/src/bidiServerRunner.ts
Line 48 in ca2e4ba
from chromium-bidi.
We need this for Puppeteer. Firefox impl supports it and it's part of the spec.
from chromium-bidi.
The best the mapper
can do is to send a error "500 | session not created", as the session is already exists at the point mapper is created. And the transport implementation (bidiServerRunner
) should implement the proper request handling.
from chromium-bidi.
Closing, as session handling cannot be handled by the Mapper.
from chromium-bidi.
Re-opening this based on the latest understanding that mapper should support multiple sessions and that it should provide handling for capabilities implementable via CDP such as ignoreHTTPSErrors
. This capability requires calling Security.setIgnoreCertificateErrors
on every target as there is no other way to implement it in Chrome.
from chromium-bidi.
Related Issues (20)
- `test_input_performActionsEmitsPointerEvents` e2e test is flaky HOT 1
- Umbrella bug for Device Request Prompt / Web Bluetooth API HOT 1
- Implement traverseHistory HOT 1
- Umbrella bug for Browser Permissions API
- Change SharedID format
- Fix race condition in local http server in e2e tests HOT 2
- Network events produce non-spec compliant JSON payload HOT 1
- Umbrella cookies
- Implement `storage.getCookies` command
- Implement `storage.setCookies` command
- Implement `storage.deleteCookies` command
- Add field `owners` in dedicated worker realm
- Document screenshots are not using document scroll height HOT 3
- Implement input.setFiles HOT 1
- [BiDi Protocol] Automate creating a mapping between Command -> Paramaters -> Result
- Flaky subscription test HOT 1
- Should we author e2e tests in a forward-compatible manner? HOT 4
- Flaky setFiles test
- eslint warnings for classes with only static methods HOT 2
- wpt/webdriver/tests/bidi/network/fetch_error/fetch_error.py is flaky HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chromium-bidi.