Code Monkey home page Code Monkey logo

Comments (6)

valbooth28 avatar valbooth28 commented on May 24, 2024 1

Awesome, thanks for your work @philipwalton!

from web-vitals.

philipwalton avatar philipwalton commented on May 24, 2024

Interesting, @npm1 can you speak to Chrome's kUserScroll and kCompositorScroll usage here? Could there be some scroll events that addEventListener('scroll') would catch but wouldn't end LCP observation?

from web-vitals.

npm1 avatar npm1 commented on May 24, 2024

We should stop on scrolling caused by user, which is not the case here. Does the listener check that the event has isTrusted set?

from web-vitals.

npm1 avatar npm1 commented on May 24, 2024

Although window.scroll() does create a trusted event despite not being caused by the user so that seems insufficient. @flackr do you know if there's a reliable way to detect user-initiated scrolls?

from web-vitals.

philipwalton avatar philipwalton commented on May 24, 2024

Ping @flackr

Unless we find a better way to detect only user-initiated scrolls, we'll likely have to drop this check and only listen for keypress and click. Ignoring scroll events won't affect the reliability of the results, but it will likely affect how soon tools like the Web Vitals Chrome Extension can report the metric as "final" (cc: @addyosmani)

from web-vitals.

flackr avatar flackr commented on May 24, 2024

There is currently no reliable way to detect user-initiated scrolls. This is because the scroll event itself is an observation of the scroll position having change rather than a direct event causing it.

You could however try to observe all possible user initiated scroll sources (mousewheel, pointerdown / pointermove, down arrow / page down / space bar?) in combination with a scrollable page.

Could you explain more the rationale around no longer observing LCP after the user scrolls? This doesn't seem like it would be guaranteed IMO.

from web-vitals.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.