Code Monkey home page Code Monkey logo

Comments (3)

addyosmani avatar addyosmani commented on May 18, 2024

@philipwalton for some alignment with the library...

How would we feel about the extension using (computed) and (still computing)?

I admit that if you haven't been a reader of some of Phil's recent docs, the notion of final/non-final isn't going to be all that clear and can imagine others being confused about what these terms mean.

from web-vitals-extension.

addyosmani avatar addyosmani commented on May 18, 2024

#32 attempts to address this.

from web-vitals-extension.

philipwalton avatar philipwalton commented on May 18, 2024

This isn't really an answer to your question, but one thing I've been thinking about w.r.t. the isFinal flag, is how it'll play out when we add bfcache to Chrome.

In those cases, I plan to reset all the metric values, and re-run the callbacks, but I'm not sure if that'll be unexpected in cases where a result was previously marked as "final".

My initial thinking is I'll add some sort of sessionID property to the metric object, which will change in the event that a page is taken out of the bfcache (or if we decide to add session boundaries on visibilitychange for long-lived pages). This will allow the metric value to be disambiguated by analytics tools from the previously sent value for the same page load, and I could say in the docs that isFinal only applies to the value from the current "sessionID".

Not sure if this will affect the extension, but I suppose it could if you're removing any listeners once the value finalizes.

from web-vitals-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.