Comments (3)
@philipwalton for some alignment with the library...
How would we feel about the extension using (computed)
and (still computing)
?
I admit that if you haven't been a reader of some of Phil's recent docs, the notion of final/non-final isn't going to be all that clear and can imagine others being confused about what these terms mean.
from web-vitals-extension.
#32 attempts to address this.
from web-vitals-extension.
This isn't really an answer to your question, but one thing I've been thinking about w.r.t. the isFinal
flag, is how it'll play out when we add bfcache to Chrome.
In those cases, I plan to reset all the metric values, and re-run the callbacks, but I'm not sure if that'll be unexpected in cases where a result was previously marked as "final".
My initial thinking is I'll add some sort of sessionID
property to the metric object, which will change in the event that a page is taken out of the bfcache (or if we decide to add session boundaries on visibilitychange
for long-lived pages). This will allow the metric value to be disambiguated by analytics tools from the previously sent value for the same page load, and I could say in the docs that isFinal
only applies to the value from the current "sessionID".
Not sure if this will affect the extension, but I suppose it could if you're removing any listeners once the value finalizes.
from web-vitals-extension.
Related Issues (20)
- INP still says “waiting for user input” even after I clicked / typed HOT 11
- Add more logging for interactions HOT 2
- Upgrade to the latest web-vitals.js attribution build HOT 7
- Upgrade to Manifest v3
- Add measures and logging for LCP diagnostics HOT 1
- Warn when CWV antipatterns are detected HOT 2
- Link to the Options page from the UI HOT 1
- Rename `master` branch to `main` HOT 1
- DevTools bfcache tester incompatible with extension HOT 2
- Spurious errors are reported when navigating to chrome:// URLs
- Unable to turn on Console Logging for Incognito Mode HOT 1
- [Feature request] Add whitelist for console logging HOT 3
- webvitals query HOT 1
- Add FCP metric
- Updates for listing in Chrome Web Store for next release.
- Why is there no web-vitals option in devtools' performance, and display the web-vitals value in timing? HOT 1
- Wrong CLS detection of elements with no opacity HOT 2
- High INP on link drag and click HOT 2
- /
- https://developers.google.com/profile/u/113452284715201417289/saved-pages?authuser=1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from web-vitals-extension.