Improve badging consistency about web-vitals-extension HOT 6 CLOSED

Not sure if this is extension-specific or a general issue with web perf APIs in Chrome. One thing to check is if these tabs are loaded in the background, in which case things like painting and layout might not actually be happening. Addy do you know how reliable LCP and CLS are when the tab is backgrounded?

Edit: Oh, if the results are in the drill-down then that means the APIs are already returning data. So this seems like a race condition of some kind for the badge.

Here's a simple way to reproduce the issue:

1. open a new tab and navigate to https://github.com/GoogleChrome/web-vitals-extension/issues, the badge should show results (green for me)
2. go back to this page, right click the new tab and reload
3. the /issues tab badge should now be gray and expanding it reveals that metrics like LCP and CLS are finalized

from web-vitals-extension.

The issue seems to be with this if statement in the chrome.tabs.onUpdated event listener:

When a tab is loaded in the background, its status will be complete, its URL will start with http, but its active property will not be true.

There is a chrome.tabs.onActivated event, but it fires for every time a tab becomes visible, even after it's already been active once before. It may not be a big deal to call getWebVitals on every activation change, or we can keep track of tabs that have already been activated and get their vitals only once per page load.

from web-vitals-extension.

Thanks for digging in to some of the racy behavior with badging, Rick!

When a tab is loaded in the background, its status will be complete, its URL will start with http, but its active property will not be true.

Good catch!

It may not be a big deal to call getWebVitals on every activation change, or we can keep track of tabs that have already been activated and get their vitals only once per page load.

I'm leaning towards the first option (calling on each activation change) but keeping in mind tracking tabs already activated and getting their vitals only once per page load as an option in our back-pocket should we need it.

That said, do you have a personal preference between the two options?

from web-vitals-extension.

I've been testing the extension with the first option and it seems to fix this particular issue, but introduces a new class of issues like #7. Also, metrics seem to be stuck as "not final".

There don't seem to be any negative side-effects of calling getWebVitals on each activation change.

from web-vitals-extension.

Could/should this be closed now that #8 is merged? Anything else you want to do to improve consistency?

from web-vitals-extension.

I think we should go ahead and close this one. If we notice folks are experiencing badging and inconsistency of any sort, we can file a new bug :)

from web-vitals-extension.