Comments (2)
This is true for all short pages, e.g. https://chromestatus.com/myfeatures/starred.
chromium-dashboard/client-src/elements/chromedash-app.js
Lines 45 to 49 in 1c39888
height: 100%
property appears to fix the problem.
@KyleJu, you touched this last; do you think that's the right fix, or am I missing a better way to do it?
from chromium-dashboard.
This is true for all short pages, e.g. https://chromestatus.com/myfeatures/starred.
chromium-dashboard/client-src/elements/chromedash-app.js
Lines 45 to 49 in 1c39888
seems to have the result of giving the sidebar at least 500px regardless of the main page content, but it should really have a height of 100%... Changing that div and this one to have a
height: 100%
property appears to fix the problem.
@KyleJu, you touched this last; do you think that's the right fix, or am I missing a better way to do it?
I think that will fix the issue. 500px might come from the minimum height from the content container, that shows the feature list. It is an issue when the list is empty.
Thanks for the fix!
from chromium-dashboard.
Related Issues (20)
- Assigning a reviewer should create an Activity record on the gate
- Replace client-side type annotations with OAS objects
- Escalation emails should ignore obsoleted features.
- accurate-as-of should have both links go to the accurate-as-of page HOT 3
- Adding a rollout step from the edit-all page fails
- Decrease line spacing in the intent emails
- Intent to ship links are often broken in the API owners dasboard HOT 2
- chrome --print-to-pdf command not saving pdf begining on 128 version HOT 1
- Obsoleted features should not be included in the roadmap
- New "intent thread" detection logic still seems broken HOT 1
- iPhone
- I'm so very upset and disappointed HOT 1
- Escalation emails should only be sent to the owner
- Move the action in escalation emails closer to the top
- Make email notifications to API Owners more distinct from those sent to feature owners
- Why would you incorporate something that causing problems
- Why aren't i getting any messages
- Fix HOT 3
- Feature - Blocking of any geo-locations / any feature by hacking / hackers HOT 1
- Highlight outdated feature entries for upcoming releases HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chromium-dashboard.