Code Monkey home page Code Monkey logo

Comments (2)

jyasskin avatar jyasskin commented on September 23, 2024

This is true for all short pages, e.g. https://chromestatus.com/myfeatures/starred.

#content {
margin: 0;
position: relative;
min-height: 500px;
}
seems to have the result of giving the sidebar at least 500px regardless of the main page content, but it should really have a height of 100%... Changing that div and this one to have a height: 100% property appears to fix the problem.

@KyleJu, you touched this last; do you think that's the right fix, or am I missing a better way to do it?

from chromium-dashboard.

KyleJu avatar KyleJu commented on September 23, 2024

This is true for all short pages, e.g. https://chromestatus.com/myfeatures/starred.

#content {
margin: 0;
position: relative;
min-height: 500px;
}

seems to have the result of giving the sidebar at least 500px regardless of the main page content, but it should really have a height of 100%... Changing that div and this one to have a height: 100% property appears to fix the problem.
@KyleJu, you touched this last; do you think that's the right fix, or am I missing a better way to do it?

I think that will fix the issue. 500px might come from the minimum height from the content container, that shows the feature list. It is an issue when the list is empty.

Thanks for the fix!

from chromium-dashboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.