Version v0.15.2 and kill chrome instance about chrome-launcher HOT 3 CLOSED

This was changed in #269

Killing a process is really just sending a signal, which is synchronous, and is why the original interface of returning a Promise was not ideal. See https://nodejs.org/api/process.html#processkillpid-signal

We should update our documentation. Thanks for catching this!

from chrome-launcher.

BTW - it's important to note that if you are wanting to wait for confirmation that the process is gone, you'll have to listen to the child process's exit event: https://nodejs.org/api/child_process.html#event-exit

from chrome-launcher.

Perfect!!

Now we are using exactly the approach that you are suggesting but since in the previous implementation there was this promise, we were relying on it!. And that is rights we need some feedback / confirmation / error handling to be ensure there is not hang chrome process there :)

The main problem was the mismatch Documentation - Code :) but we always trust on the code hahahah

We can close the thread

from chrome-launcher.