Code Monkey home page Code Monkey logo

Comments (4)

mzgoddard avatar mzgoddard commented on September 23, 2024

@hoch Ah. Transitioning to no graph (either by navigating away from the page or the last audio context being destroyed) isn't pushing a new graph (or rather a lack of one) to the layout thread. I think we could replace the filter in GraphSelector with a default empty graph. That would push the empty graph to the layout worker and the result from the worker would delete the previous nodes.

I'll post a PR for that.

from audion.

hoch avatar hoch commented on September 23, 2024

I am reopening this because the PR did not completely fix the issue.

Technically the observer is doing what it is supposed to do. There's no signal from the Web Audio inspector (Blink) after the page is unloaded, so the visualizer won't be updated.

I think one possible workaround is to capture an event of "navigating away", and reset the state in the extension.

from audion.

richnoah avatar richnoah commented on September 23, 2024

@hoch for this would you be able to specify the url you were going back to? Any urls you can provide that do not work with the back button we would like documented.

from audion.

hoch avatar hoch commented on September 23, 2024

Just revised the description - not only that I just tried to reproduce the issue, but it seems to be fixed. :)

Let me sit on it a couple of more days before closing this.

from audion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.