Code Monkey home page Code Monkey logo

Comments (7)

frankyn avatar frankyn commented on August 10, 2024

@tseaver I misunderstood this file -> https://github.com/googleapis/python-storage/blob/master/tests/unit/url_signer_v4_test_data.json

I understood this JSON file as being the cross-language conformance tests.

from python-storage.

tseaver avatar tseaver commented on August 10, 2024

Hmmm, looks like that is conformance tests. Dunno how I missed that they existed already. Looks like an older version of the file?

from python-storage.

frankyn avatar frankyn commented on August 10, 2024

+1, I recently changed the schema and added conformance tests for Signed Policies.

from python-storage.

tseaver avatar tseaver commented on August 10, 2024

Suggested implemenation plan:

  • Move the test drivers for signing out into a separate file, like the test_cross_language.py file in python-firestore.
  • Rename the data file to match the upstream name (v4_signatures.json).
  • Copy in the new test data file, update the test drivers to match the new schema, if needed, and fix anything broken.
  • Add a test driver for the Signed Policy testcases.

from python-storage.

tseaver avatar tseaver commented on August 10, 2024

I have a branch which implements the first two steps cleanly, and a stash for the third one, where some of the tests no longer pass. Actually landing the new tests is going to need to wait for PRs #48 and #56 to land, I think.

from python-storage.

frankyn avatar frankyn commented on August 10, 2024

@HemangChothani, @tseaver is tracking conformance test updates in here. Referenced issues are merged/unblocked.

from python-storage.

frankyn avatar frankyn commented on August 10, 2024

This was fixed by @IlyaFaer

from python-storage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.