Avoid long tasks that block ad-related network requests (show_ads_impl_fy2019.js) about publisher-ads-lighthouse-plugin HOT 8 CLOSED

Could you share the URL of the page(s) you were testing and clarify how you were running the tool, so the team can take a closer look?

from publisher-ads-lighthouse-plugin.

To run the tool, I'm just entering the page URL directly from: https://developers.google.com/publisher-ads-audits/

The page is at: https://www.ifate.com/runes.html

Btw -- the inclusion of Auto Ads' adsbygoogle.js on the page seems to be causing an additional issue as well:

• Original Issue: show_ads_impl_fy2019.js is being flagged as a long task which blocks ad-related networks requests. As noted previously, this script is part of adsbygoogle.js and is necessary to show ads.
• Additional Issue: There is an additional "Ad Request Waterfall" warning to render ads using lazy loading -- but the flagged 'slots outside the viewport' are: "aswift_1", "aswift_2", ... "aswift_6". These are dynamically generated placements created by Auto Ads. AFAIK there is no way to implement lazy loading for these, as advised.

This is concerning because it looks like Auto Ads may negatively impact viewability (?)

from publisher-ads-lighthouse-plugin.

Hi - starting work on this now. I am able to reproduce both the original issue and the additional issue using the URL you provided. I'll post updates as they're available...

from publisher-ads-lighthouse-plugin.

Also, @Bangkokian: possibly unrelated to the current bug, but when I load https://www.ifate.com/runes.html I see <script async='async' src='https://www.googletagservices.com/tag/js/gpt.js'></script> repeated 6 times. Also you're loading adsbygoogle twice. So I think the reason for "Ad request waterfall" is that perhaps a later request for adsbygoogle is coming after an ad request that resulted from one of the earlier instances of those scripts.

from publisher-ads-lighthouse-plugin.

from publisher-ads-lighthouse-plugin.

Partially fixed with #193

from publisher-ads-lighthouse-plugin.

Great - thanks for removing the extra gpt.js inclusions. I do still see adsbygoogle.js included twice, though.
Breaking the issues down:

• “Avoid long tasks that block ad-related network requests” - this is a bug. Thanks for finding it! It is fixed in #193.
• “Ad request waterfall” - it is the case that adsbygoogle.js is being loaded after an ad request that comes from gpt.js. So I feel that the tool is working as intended. Just checking, is it intentional that you have both GPT and AdSense running on the same page? If so, that’s fine - I just want to verify this is intentional. If you indeed need both of them, it may help to move the inclusion of adsbygoogle.js to above all the googletag.cmd.push calls.
• “Avoid loading ads until they are nearly on-screen” - If using only GPT, enabling lazy loading as described in the audit should take care of things. I have created #194 to disable this audit for Adsense-only sites.

from publisher-ads-lighthouse-plugin.

from publisher-ads-lighthouse-plugin.