ReportDownloader - Bad Gateway exception about googleads-java-lib HOT 3 CLOSED

Thanks for pointing this out. I'll take a look -- seems like we need a try/finally in the code that's parsing the exception XML, as you mentioned.

from googleads-java-lib.

On closer examination, I realized that the library does throw a ReportDownloadResponseException in this scenario. The log messages you mentioned are coming from the catch(SAXException) block in XmlFieldExtractor.extract, which logs any XML parsing issues (instead of throwing them) so that parsing issues won't mask the underlying exception.

After the XML parsing errors are logged, the ReportDownloader will proceed past the call to XmlFieldExtractor.extract and throw the DetailedReportDownloadResponseException. Below is the relevant code from ReportDownloader, with some additional comments for clarification.

    DetailedReportDownloadResponseException exception =
        new DetailedReportDownloadResponseException(response.getHttpStatus(), responseText);
    XmlFieldExtractor extractor = new XmlFieldExtractor();
    // Exceptions thrown by the call to 'extract' are logged,
    // but not rethrown.
    Map<String, String> fields = extractor.extract(
        new ByteArrayInputStream(responseText.getBytes()),
        new String[] {"fieldPath", "trigger", "type"});
    // Will still reach this point, even if an exception occurred
    // within the call to 'extract' above.
    exception.setFieldPath(fields.get("fieldPath"));
    exception.setTrigger(fields.get("trigger"));
    exception.setType(fields.get("type"));
    throw exception;

from googleads-java-lib.

As far as I can tell, this is working as intended. Please see my previous comment and reopen if you still see an issue.

from googleads-java-lib.