Code Monkey home page Code Monkey logo

Comments (5)

jsiedentop avatar jsiedentop commented on May 22, 2024 2

I can confirm that the test app can compute a hash hangs on my mac if the example application is in the background during the test (Mac M1, macOS 14.1 23B74 darwin-arm64). However I was able to run the test.yml Action successfully on GitHub, without any relevant change:

image

from webcrypto.dart.

jonasfj avatar jonasfj commented on May 22, 2024 2

Merged #77 and closing this for now.

If someone is interested in trying to figure out if this is an flaky, and/or what we could do to make it work better, please go ahead.

Contributions are welcome, please ping me @jonasfj for reviews (I'm sometimes slow to notice PRs).

from webcrypto.dart.

CoreNion avatar CoreNion commented on May 22, 2024 1

On the actual machine, the test appears to get stuck on the step 'test app can compute a hash' if the example app is not the active window.
The test passes when the app is open, which is why I did not notice the issue.
This part runs testWidgets(), but it is likely not being handled by the app GUI on GitHub Action and is causing the test to hang?

from webcrypto.dart.

jsiedentop avatar jsiedentop commented on May 22, 2024

At least it seems, that the library itself seems to work like expected.

If the cause of the flaky test is really, that the application looses focus, then I would investigate:

  • if the test should work without focus?
  • why the app looses focus at all?
  • is there a way to rewrite the test to make it more stable.

I would argue, that it’s a separate topic. I keep it in mind and maybe will come back to this, if it turns out to be a big problem. However, sporadic errors that occur in the pipeline could be quite difficult to isolate.

from webcrypto.dart.

jonasfj avatar jonasfj commented on May 22, 2024

I just landed #78 and will publish.

But I had to manually rerun the tests to get it to pass.

  • First time it timed out after 12 minutes.
  • Second time it finished in 2 minutes.

Ideas for what we can do to make flutter test integration_test/webcrypto_test.dart -d macos reliable are welcome.

The flutter part of the example app we have here are really dumb and simple. Nothing fancy, so this could be a bug in Flutter somewhere. Or it could be a bug in flutter integration test logic.

from webcrypto.dart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.