`weather-mv`: Add columns to Schema for faster geolocation queries about weather-tools HOT 3 CLOSED

I have a feeling that this is the function that I should be working on
I'll add the value of ST_GeogPoint(longitude,latitude) to the existing column

This sounds right to me. I recommend looking at the logic here (https://github.com/google/weather-tools/blob/main/weather_mv/loader_pipeline/pipeline.py#L370). I think the column should be added around this area, and to the associated functions. Check out this BQ documentation, too: https://cloud.google.com/bigquery/docs/geospatial-data

Would you say that trying to understand the code while fixing this issue be a good starting point?

Yes, I think this is a great starting point. If you'd like additional help, maybe we can set up a 1:1 meeting.

Also, I would greatly appreciate it if you could share any good practices I should follow or keep in mind when contributing to a preexisting project.

Sure thing. The general flow will look like:

• Fork the project
• Make the change in a new branch (not the main branch)
• Test your code (unit tests, manually e2e)
• Send a draft pull request into the main branch (see the Github docs for clarity on how to do this)
• Review the code yourself, see if you can catch any errors before it goes to final review. Also, you can see if any errors have occurred on the automated check system (to run them locally, use bin/post-push)
• Once it's ready, send the code out for review
• iterate on the branch until all outstanding feedback is addressed
  • if you need help testing the pipelines e2e, please say so.
• Change will be merged into main.

How does all that sound?

from weather-tools.

Hi @alxmrs, I plan on working on this but I am still in the process of trying to understand the code.
https://github.com/google/weather-tools/blob/82971d0559c0d567133e8191d4112a0879a0d888/weather_mv/loader_pipeline/pipeline.py#L250
I have a feeling that this is the function that I should be working on and that I'll add the value of ST_GeogPoint(longitude,latitude) to the existing column but I'm not too sure. Would you say that trying to understand the code while fixing this issue be a good starting point? Also, I would greatly appreciate it if you could share any good practices I should follow or keep in mind when contributing to a preexisting project.

from weather-tools.

Heads up: The files changed around a lot in #101.

from weather-tools.