[cppbindings] External application build fails if WTF_PTHREAD_THREADED is not defined about tracing-framework HOT 3 CLOSED

I don't have the source on this device to check but I believe you are right with respect to needing that define. I think that if no threading macro is defined, it just tries to use the std c++ library for threading -- but that has varying levels of support, even on platforms that otherwise support c++11. I'll add some documentation about how to integrate it into other projects. Tbh, the makefile was just written to allow us to build it standalone outside of our build environment, so it has not gotten a ton of love. On Feb 12, 2017 11:39 AM, "Ihor Ivlev" <[email protected]> wrote: The failure is undefined reference to "PlatformGetThreadLocalEventBuffer". It is inlined in pthreads platform header (https://github.com/google/ tracing-framework/blob/master/bindings/cpp/include/wtf/ platform/platform_aux_pthreads_threaded_inl.h#L42) which is only included in case WTF_PTHREAD_THREADED is defined: https://github.com/google/tracing-framework/blob/master/ bindings/cpp/include/wtf/platform.h#L52 Could you please clarify whether defining WTF_PTHREAD_THREADED is required while building external application (in this case it would be nice to document it somewhere).. Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#583>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAeKgMZ-w9LFvqYwhj9qsYJ4KCZXv9KZks5rb1_ugaJpZM4L-lsb> .