No error details when exceeding of LengthDelimitedCodec's max frame length about tarpc HOT 6 CLOSED

I have published the fix in v0.32.0. Thanks again!

from tarpc.

Thank you for raising this! I'm sorry it made incident mitigation more difficult.

Just to double check, the limit you ran into was the client-side limit? I think I can pretty easily add a better error message when the client stops an RPC from being sent. Here's a prototype:

2023-01-10T02:49:32.528939Z  WARN client: the client failed to send the request

Caused by:
    0: could not write to the transport
    1: frame size too big

(On the server side, it's more complicated for the server to remediate the byte stream if there is a lot of junk on the stream from a request that is too large.)

from tarpc.

Yes, the limit we ran into was on the client-side, because a parameter of a request was too big.

I just confirmed this with a test that sets the max frame size to something very low on the client and something very high on the server, and my test failed with the mentioned RpcError::Disconnected on the client side. (Typically we have the same limits on both the client and the server, however.)

That being said, I could imagine a similar issue happening on the server if a response gets too big.

Thanks for creating a prototype so quickly! An error message containing such specific error details ("frame size too big") in a new enum variant (RpcError::Send in your prototype) would definitely be very helpful (and would certainly have helped in our debugging).

from tarpc.

@tikue any chance of moving forward with the prototype? I am looking at a similar issue where it's hard to understand the underlying cause. It would be very helpful to have this kind of information available

from tarpc.

Hey, sorry for the delay here! I've been busy and haven't had time to work on this. I'd be happy for someone else to pick it up. The main thing missing from the above was tests.

from tarpc.

@tikue thanks for replying, I have cherry picked your commits and added a test. Let me know if the direction looks good and if anything else is missing.

from tarpc.