Integrate `<ConversionTrackingToggle />` Component Into Ads and GA4 `<SettingsEdit />` Components about site-kit-wp HOT 8 OPEN

AC ✅

Moving to IB

from site-kit-wp.

• Toggle will handle saving the settings to the CORE_SITE store independently, so the focus of this issue is placing the rendered component in right place as per design and adjusting the wrapper spacing . Styling can be applied in assets/sass/components/ads/_googlesitekit-ads-settings.scss

@zutigrm this line is not correct anymore. We don't need to mention anything about saving because there are no action items for it in this task, it will be handled in another one. Let's remove it to not confuse anyone who will work on it.

from site-kit-wp.

@eugene-manuilov Thanks, IB updated

from site-kit-wp.

Thanks, @zutigrm. IB ✔️

from site-kit-wp.

QA Update ❌

• Tested on dev environment.
• Verified Ads module edit settings view for non PAX manner and PAX manner.
• Verified that toggling the value and saving persists the value on the next page load/reload.

@10upsimon

Issue

If the user does not click the "Save" button after changing the toggle value, the toggle value is still getting updated under the settings view. Upon reloading the page, the toggle value reverts to its original status.

Expected Behavior: If the user does not click the "Save" button, the toggle value should not change under the edit view.

Steps to Reproduce:

1. Disable/Enable the toggle button.
2. Click on the "Cancel" button.
3. Notice that the toggle value updates as per the selection in step 1.
4. Reload the page.
5. Observe that the toggle value reverts to the value before step 1 because the "Save" button was not clicked.

Pass Cases

from site-kit-wp.

@mohitwp This has been fixed in #8821 , you can confirm the fix there once it lands in QA

from site-kit-wp.

QA Update

Blocked due to #8821.

from site-kit-wp.

QA Update ✅

• Tested on dev environment.
• Verified Ads module edit settings view for non PAX manner and PAX manner.
• Verified that toggling the value and saving persists the value on the next page load/reload.
• Issue reported above is resolve under #8821.

from site-kit-wp.