Comments (4)
@sviluppomania Thanks for the info, I have filed this as a bug now for further investigation
from site-kit-wp.
Hello @jamesozzie ,
as you can see from my report, there are many compatibility errors with PHP 7 and higher versions.
As you can still see, the directory that leads to the file and all the errors are in bold.
A question:
Why didn't you consider sites that use PHP 7?
System Information (please complete the following information):
PHP Version: 7.3.6.
OS: Windows 10
Browser: Google Chrome
from site-kit-wp.
@sviluppomania Thanks for the follow-up. The violations are caused by a third-party dependency we don't have control over. I will look into whether we can replace it with an alternative or solve the problems upstream.
from site-kit-wp.
phpseclib author here.
If this library isn't being used then it shouldn't be a dependency, I get it, BUT that doesn't change the fact that all but one of the "issues" identified by this static analysis tool are completely 110% bogus.
-
if mbstring is installed and mbstring.func_overload is set such that functions like
strlen
/substr
/ etc would be overloaded phpseclib throws a "Overloading of string functions using mbstring.func_overload is not supported by phpseclib" exception. See phpseclib/phpseclib#1239 -
mcrypt is only used IF IT'S AVAILABLE for speed. OpenSSL is PREFERENTIALLY USED if it's available BUT if it isn't then mcrypt is used because a pure-PHP implementation cannot hope to match even mcrypt's speed. And when it is used the error suppression operator is used. See phpseclib/phpseclib#1028
As for the one issue that isn't 100% bogus... the ${$host}
issue... I contend that fixing that issue would be a BC break. It's used for the SFTP stream wrapper. phpseclib 1.0 / 2.0 support fopen('ssh2.sftp://$session/path/to/file', 'r');
. Note the single quotes. phpseclib dev-master, however, doesn't support that. That supports fopen("ssh2.sftp://$session/path/to/file", 'r');
(note the double quotes). In-so-doing, dev-master is able to emulate libssh2's SFTP stream wrapper more faithfully than the 1.0 / 2.0 branches are. Here's the PR where this was done: phpseclib/phpseclib#787 . Now, I'll admit... the global requirement that the 1.0 / 2.0 branch has means that that functionality can't very easily be used inside of functions because you'd have to declare $session
in the function, as well. I may actually be willing to change this (backport the afore mentioned PR) in the 2.0 branch because (1) my suspicion is that it's not really being used by any projects and (2) if BC breaking in minor releases was completely verboten some bugs would be impossible to fix. I'm not sure I'd call this a "bug", as such, since it is working as designed, but, depending on my mood, I may be willing to be a little more flexible on some things.
If anyone can convince me that any of the issues raised brought up in this ticket are legit (outside of the ${$host}
issue) I will PayPal you $100 dollars. I do apologize that I can't do more but I don't have pockets nearly as deep as Google does.
But I mean, seriously, common sense, people. phpseclib is unit tested on Travis CI up to PHP 7.4snapshot. If these deprecation issues were legit the unit tests would be failing but they're not.
from site-kit-wp.
Related Issues (20)
- Consent Mode disconnection modal: Future proof copy and/or link to EU user consent policy.
- Visual issues on NPT page: 2 grey, border of grey field and fonts
- Incorrect dimension filter applied in various components that uses `adSourceName` dimension HOT 1
- Continuous loading screen if trying to edit the Tag manager module that another user connected
- Create Ads Module Setup CTA Banner HOT 6
- Create Ads PAX Setup Success Notification Banner HOT 6
- NPT Mobile Viewport issue on horizontal scroll HOT 1
- RTL languages translation for NPT HOT 1
- Release 1.127.0 HOT 6
- Refine Paragraph Styles Scope in the Authorize Application Screen HOT 1
- Ads.txt notification appears when a valid ads.txt file is already placed and recognised in AdSense
- Consider an "Start setup" plugin_action_links link after installing and activating the plugin
- Implement partner authentication service HOT 1
- Implement date range services for PAX reporting HOT 4
- Update PAX conversion tracking service for compatibility with v1 HOT 5
- Update the Ads Conversion ID migration notice to dismiss based on first view
- Dashboard Sharing errors when a user tries to change the active key metric tiles
- Avoid layout shift when showing the Setup CTA Banner.
- Only show one of the Consent Mode and Audience Segmentation Setup CTA Banners at a time.
- Visual difference in the view only vs standard SK dashboard with number of KMW tiles shown HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.