Build fail [88/99] ar -M about shaderc HOT 7 CLOSED

Thanks, @Whiteseeker for reporting this. We don't build regularly on MacOS, so support for it will be sporadic.

This looks like it's caused by the GNU-specific ar flag -M in the combine_static_lib function (defined in cmake/utils.cmake). If you can figure out how to achieve the same operation in a portable manner, you can fix this. Alternatively, if you don't care about the libshaderc_combined target, you can modify line 27 of libshaderc/CMakeLists.txt to skip this step for both Windows and MacOS.

from shaderc.

Thx for the quick fix !
I just did: if (NOT "${MSVC}" AND NOT APPLE) at line 27
There is definitely a way to merge libraries in a cross platform way like that:
ar -rcT libmerged.a lib1.a lib2.a
But I I'm not super familliar with cmake.
Again thx !

from shaderc.

Glad this worked for you. Would you consider contributing your fix to the repo?

from shaderc.

You mean ... making a pull request for one line change ? I would gladly
ofc, I'll do that.

Thx

Damien

On Tue, 1 Dec 2015 at 16:35 Dejan Mircevski [email protected]
wrote:

Glad this worked for you. Would you consider contributing your fix to the
repo?

—
Reply to this email directly or view it on GitHub
#47 (comment).

from shaderc.

Prolly more than one line, as you should also add yourself to CONTRIBUTORS. ;)

from shaderc.

PR submitted! It took some time but at least it's a "real" fix, it also
create the shared lib on mac and pass the test.
Currently it only fail the last test on mac:

14/14 Test #14: glslc_tests ......................***Failed 0.11 sec

Thx !

On Tue, 1 Dec 2015 at 17:50 Dejan Mircevski [email protected]
wrote:

Prolly more than one line, as you should also add yourself to
CONTRIBUTORS. ;)

—
Reply to this email directly or view it on GitHub
#47 (comment).

from shaderc.

Closing

from shaderc.