Code Monkey home page Code Monkey logo

Comments (3)

protobufel avatar protobufel commented on June 9, 2024
  1. Is there any ETA for the fix? This bug renders entire DynamicMessage unusable - any merge, build, clone, parse, etc. methods won't work in the presence of any repeated enum field!

The bug is a MAJOR one, a showstopper!

Thanks in advance,
David

from protobuf.

xfxyjwf avatar xfxyjwf commented on June 9, 2024

Sorry, we don't have an ETA for this. It should be fixed in the next minor release which hasn't been scheduled yet.

I believe most uses of DynamicMessage still work as we have unit-tests covering DynamicMessage:
https://github.com/google/protobuf/blob/master/java/src/test/java/com/google/protobuf/DynamicMessageTest.java

Presumably these tests are not failing despite of the bug. In most places we use addRepeatedField()/setRepeatedField() instead of setField() to manipulate repeated fields. Users could use these methods as a workaround as well.

from protobuf.

protobufel avatar protobufel commented on June 9, 2024

Nope, the merge uses setField, and the clone, new builder, and build, and
the rest use the merge!

This is really the showstopper! Update the tests and you'll see it!

Also, most of the users will care only about the Maven Central, so this
minor emergency release could be done just for Java there.
On Sep 10, 2014 1:12 PM, "xfxyjwf" [email protected] wrote:

Sorry, we don't have an ETA for this. It should be fixed in the next minor
release which hasn't been scheduled yet.

I believe most uses of DynamicMessage still work as we have unit-tests
covering DynamicMessage:

https://github.com/google/protobuf/blob/master/java/src/test/java/com/google/protobuf/DynamicMessageTest.java

Presumably these tests are not failing despite of the bug. In most places
we use addRepeatedField()/setRepeatedField() instead of setField() to
manipulate repeated fields. Users could use these methods as a workaround
as well.


Reply to this email directly or view it on GitHub
#17 (comment).

from protobuf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.