Mixins need to enforce read-only behavior for default instance about protobuf.dart HOT 2 OPEN

Currently the _isReadOnly getter is private. We should make it public

We now have a getter for _isReadOnly:

I don't understand the story with mixins enough to comment on whether the problem with not enforcing read-only behavior in mixins still exist..

EDIT: Just learned that PbMapMixin is to provide a map-like interface for messages.

from protobuf.dart.

At the time I added mixins, there were only a few, either in the open source code or in the google3 version. If all the mixins handle readonly protobufs correctly then there is no issue. It might be good to update them to call isFrozen?

I think this bug was to document the workaround and to warn about what might go wrong if the ability to add mixins was used more widely. (For example, users started writing their own mixins.)

It probably could be closed. If someone were to write a guide to implementing protobuf mixins then it should have a reminder to handle the frozen case correctly, but it doesn't seem too likely?

from protobuf.dart.