.setup= argument to allow re-usable (but hermetic) local variables? about patrick HOT 1 OPEN

generate_cases <- function() {
  # Note: cases indicated by "*" are whole numbers, but don't lint because the user has
  #   effectively declared "this is a double" much as adding '.0' is otherwise accepted.
  cases <- tibble::tribble(
            ~num_value_str, ~should_lint,
                     "Inf",        FALSE,
                     "NaN",        FALSE,
                    "TRUE",        FALSE,
                    # ... And many more cases ...
                    "8.0i",        FALSE
  )
  # for convenience of coercing these to string (since tribble doesn't support auto-conversion)
  int_max <- .Machine[["integer.max"]]  # largest number that R can represent as an integer
  cases_int_max <- tibble::tribble(
    ~num_value_str, ~should_lint,
    -int_max - 1.0,        FALSE,
          -int_max,         TRUE,
           int_max,         TRUE,
     int_max + 1.0,        FALSE           int_max,         TRUE,
     int_max + 1.0,        FALSE
  )
  )
  cases_int_max$num_value_str <- as.character(cases_int_max$num_value_str)
  cases <- rbind(cases, cases_int_max)
  cases$.test_name <- sprintf("num_value_str=%s, should_lint=%s", cases$num_value_str, cases$should_lint)
  cases
}

patrick::with_parameters_test_that(
  "single numerical constants are properly identified ",
  {
    linter <-  implicit_integer_linter()
    expect_lint(num_value_str, if (should_lint) "Integers should not be implicit", linter)
  },
  .cases = generate_cases()
)