Code Monkey home page Code Monkey logo

Comments (4)

dpursehouse avatar dpursehouse commented on July 28, 2024

while you're in the monsoon module, it might be worth fixing these problems highlighted by pyflakes:

mobly/controllers/monsoon.py:300: list comprehension redefines 'x' from line 298
mobly/controllers/monsoon.py:476: local variable 'voltage_str' is assigned to but never used
mobly/controllers/monsoon.py:477: undefined name 'voltage'
mobly/controllers/monsoon.py:641: undefined name 'mon'
mobly/controllers/monsoon.py:709: local variable 'history_deque' is assigned to but never used
mobly/controllers/monsoon.py:745: local variable 'e' is assigned to but never used

from mobly.

xpconanfan avatar xpconanfan commented on July 28, 2024

Also need to clean up sleeps

from mobly.

winterfroststrom avatar winterfroststrom commented on July 28, 2024

Need to also make it testable/add tests as we have basically no unit test coverage for it right now

from mobly.

xpconanfan avatar xpconanfan commented on July 28, 2024

The Monsoon controller code is now removed in favor of Monsoon's official solution

from mobly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.