Code Monkey home page Code Monkey logo

Comments (7)

tomByrer avatar tomByrer commented on May 2, 2024

our PNGs could be optimized further

Yep, took a minute to compress 6 random PNGs, & got 20-35% reduction in filesize. Even if you had to do it "by hand" (I just drag & dropped a folder into my tool), couldn't you do that before release please?
Perhaps this should have been tagged v0.1.0 instead of v1.0.0?

from material-design-icons.

addyosmani avatar addyosmani commented on May 2, 2024

So, I actually did go through and manually optimize the PNGs before release :) In the end we decided to go ahead with the script-generated versions of the icons for V1.

That might sound crazy, but it's because (for now) we want the Google (internal) version of these icons to be the source of truth and minimizing the difference of what is in this repo and there makes it easy to keep the public version up to date.

Soon, we hope to integrate proper PNG and SVG optimization into our pipeline so that everything we sync back to this repo is kept as small as possible (hopefully for 1.0.x). We definitely do care about byte-shaving :)

Perhaps this should have been tagged v0.1.0 instead of v1.0.0?

Nope! We're following npm's more recent semver recommendations, which suggest starting with 1.0.0 and iterating on that baseline rather than opting for the more classic 0.x.y model. We're new to it too, so still working out how well that model works.

from material-design-icons.

tomByrer avatar tomByrer commented on May 2, 2024

because (for now) we want the Google (internal) version of these icons to be the source of truth

Ohhh, that explains alot, thanks. Shouldn't this be in the README then? I've learned to look into the issues to see if something is truly ready to go for consumption (or in my case CDN hosting), but most others will see v1.0.0 & immediately start using.

following npm's more recent semver recommendations

Yes, I watched that thread also. I do think people are too afraid to bump up to 1.0.0. But I think v1.0.0 should be 'ready to consume'. Perhaps I'm too much of a perf nerd, but even you agree there needs to be more steps to be truly ready. I would have released as v0.6.0; "We're more than half-way there".

from material-design-icons.

j9t avatar j9t commented on May 2, 2024

(Seconding @tomByrer’s point. Average savings through ImageOptim are about 25%. Holding off a pull request per the discussion here.)

from material-design-icons.

tomByrer avatar tomByrer commented on May 2, 2024

Yep, I used tool a similar to ImageOptim for Windows.
Obviously gulp-imagemin is a non-answer for some, so I hope a more universal tooling is figured out.

from material-design-icons.

ilanbiala avatar ilanbiala commented on May 2, 2024

+1 optimization would be great at least for the released icons. Maybe have a Travis worker build these and do the release?

from material-design-icons.

shyndman avatar shyndman commented on May 2, 2024

We've ultra optimized everything, and will continue to do so.

from material-design-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.