Code Monkey home page Code Monkey logo

Comments (12)

jestelle avatar jestelle commented on May 2, 2024

Could you point me at where I could see the specific bugs triggered?

If I look here, http://commons.wikimedia.org/wiki/Category:Material_design_icons, I can visually see some that look incorrect.

Our SVGs should be pretty simple and clean though, so I'm actually surprised to hear you're seeing bugs, and surprised to see so many rendering poorly.

Give me some more detail and I'll help fix this.

from material-design-icons.

evgenyz avatar evgenyz commented on May 2, 2024

This one: http://bugzilla.gnome.org/show_bug.cgi?id=620923 (absence of leading zeroes).

from material-design-icons.

ebraminio avatar ebraminio commented on May 2, 2024

Yes, usually leading zeros missing is the case.in simple paths shapes.

from material-design-icons.

tomByrer avatar tomByrer commented on May 2, 2024

Without leading 0 is within spec. Gnome still hasn't fixed a 4+ year old bug; that's on them. I would prefer not to have to add extra code that's not needed by 95% of the other usecases.

from material-design-icons.

evgenyz avatar evgenyz commented on May 2, 2024

Yeah, that's absolutely Gnome's folks are to blame. But this is just a couple of zeroes (and having leading zeroes is also perfectly up to specs) to make 100% happy.

from material-design-icons.

CaliLuke avatar CaliLuke commented on May 2, 2024

I don't think this project should be in the business of backfilling for other people's bugs. The right people to ask for a fix are the Gnome team.

from material-design-icons.

jestelle avatar jestelle commented on May 2, 2024

Thanks for all the detail all.

Our SVGs are correct and within the SVG spec to the best of my knowledge.

The issue of missing leading zeros (and spaces), is one that uncovers bugs in a number of platforms that handle SVGs, so we may change our format in the future. Stay tuned.

from material-design-icons.

ebraminio avatar ebraminio commented on May 2, 2024

@behdad fixed the bug on librsvg and Commons also applied the patch so this is no longer an issue. Thanks everyone!

from material-design-icons.

addyosmani avatar addyosmani commented on May 2, 2024

That's great to hear. Thanks for the update @ebraminio!

from material-design-icons.

evgenyz avatar evgenyz commented on May 2, 2024

That's great, but fixed librsvg will land into distributions only in spring cycle, I believe. Also there are other affected libs to keep in mind as far as I understand.

from material-design-icons.

behdad avatar behdad commented on May 2, 2024

Do you guys pass your SVGs through svgo? That's how I discovered the bug (in the context of Noto Color Emoji). If you have other optimization technics, I like to hear.

from material-design-icons.

behdad avatar behdad commented on May 2, 2024

Actually a release of librsvg was made recently by @hughsie. It's 2.40.6, which means distros should be able to pick it up in their updates.

from material-design-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.