Unable to build shared library on Windows (MinGW-w64) about highway HOT 9 CLOSED

same here

from highway.

when I compile with verbose mode, what is passed to compiler is -Dhwy_contrib_EXPORTS not -Dhwy_EXPORTS. So, according to highway_export.h, HWY_DLLEXPORT is defined to __declspec(dllimport)

from highway.

That is only true if HWY_SHARED_DEFINE is not defined, because if it is HWY_DLLEXPORT is empty, see the code from hwy/highway_export.h I mentioned above.

from highway.

#413 would still be nice to have 😉

from highway.

Apologies, I used the wrong macro: it should have been HWY_CONTRIB_DLLEXPORT for anything in hwy/contrib. Fixing shortly.

That aside, I'm not sure it actually makes sense to use shared libraries for Highway. There's not a lot of code that can actually go into the .so/.dll, and maybe it's more trouble than it is worth?

from highway.

@kmilos we can certainly add the LANGUAGES CXX to CMakelists, I'm not sure the other prefix change is still relevant because we now instead set RUNTIME_OUTPUT_DIRECTORY?

from highway.

I was suggesting at MSYS2 in the CI in general...

from highway.

hm, when we last tried enabling it, there were numerous issues. Do you have any statistics on how many projects are using Highway with MSYS/MinGW? Would anyone be willing to help with these and future issues?

from highway.

Do you have any statistics on how many projects are using Highway with MSYS/MinGW?

So far libjxl and libvips depend on it directly in the MSYS2 repo https://packages.msys2.org/package/mingw-w64-ucrt-x86_64-highway?repo=ucrt64 and then all of their clients. It's hard to tell who else uses it indirectly, outside the repo...

from highway.