Unable to create Custom Repository Role without permissions about go-github HOT 6 OPEN

I understand your point now. It makes perfect sense.

I changed the PR in such a way, that it doesn't break the current API.
However, I couldn't run tests locally without fails. The fails I see look not relevant for changes I have added

from go-github.

It sounds like we need a new endpoint with an additional private struct which removes the omitempty from the existing CreateOrUpdateCustomRoleOptions struct, but is otherwise identical. We've done things like this in other places.
For example, here:

@andriyun - would you like to make a PR to address this, or shall I open this up to other contributors to this repo?

from go-github.

I'll be glad to submit PR with changes to fix it :)

from go-github.

Thank you, @andriyun ! It's yours.

from go-github.

Hey @gmlewis
Sorry for late question. I didn't get your idea about creating new endpoint. I could neither find other cases you are referring too.
It's true at there are some similar constructions there with CreateOrUpdate****Options
However there are not used separate Create Update` methods.

I've added PR with changes #3235
Please take a look

from go-github.

So I was thinking that this could be achieved without breaking the current API by adding separate endpoint(s) that specifically handle the NoPermissions case, and internally uses modified structs where the omitempty has been removed from the permissions field.

Does that make sense?

I've looked at #3235 but was hoping to not break the current API, which that PR does.

from go-github.