Code Monkey home page Code Monkey logo

Comments (2)

jamesbarnett91 avatar jamesbarnett91 commented on July 17, 2024

We are also hitting this issue. Seems like it's linked to a recent change to Quay which must have just been rolled out to quay.io: quay/quay#2884

There is a small wrinkle though: as per the OCI spec, a client is still allowed to request an arbitrarily high number of tags to be returned in a single API call, which we so far silently ignored and returned the configured maximum. Now we return an HTTP 413 response, which technically is against the spec but needed in order to protect the registry against rogue clients and also return a clear error signal instead of less tags than the client asked for

So their limit always was 100 but was being silently ignored before, whereas now they throw an error.

Seems like there is already logic to set the current 1000 limit for non-Google registries, maybe this now needs a similar check for quay.io to set to n=100?

// ECR returns an error if n > 1000:
// https://github.com/google/go-containerregistry/issues/681
if !isGoogle(repo.RegistryStr()) {
uri.RawQuery = "n=1000"
}

Or ideally a way to specify the page size via the cli

from go-containerregistry.

khrisrichardson avatar khrisrichardson commented on July 17, 2024

It looks like quay fixed this on their end: fluxcd/image-reflector-controller#585 (comment)

from go-containerregistry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.