Asynchronous/double-buffering support? about glog HOT 7 OPEN

This sounds like a great feature. Holding up any thread to block on expensive I/O operations is a bad idea. There should be a way to set things up so a background thread handles all I/O.

from glog.

FWIW I ended up implementing this using existing public glog APIs, in case anyone's interested in borrowing the code for their projects (or for distribution as part of glog)

https://github.com/apache/kudu/blob/master/src/kudu/util/async_logger.h
https://github.com/apache/kudu/blob/master/src/kudu/util/async_logger.cc
https://github.com/apache/kudu/blob/master/src/kudu/util/logging.cc#L129 (EnableAsyncLogging)

from glog.

An additional enhancement with caveats is to replace the mutex with a lock-free queue, there is discussion by the author of g3log here:

https://kjellkod.wordpress.com/2015/06/30/the-worlds-fastest-logger-vs-g3log/

from glog.

@toddlipcon ：hi，have you benchmark kudu's async_logger？with native glog？

from glog.

I didn't do throughput benchmarks, but the async logging solved a lot of blocking issues that we saw before where critical parts of our code would get "stuck" for several hundred milliseconds. Throughput is likely improved as well, but that's rarely a consideration for our app, so we didn't test it.

from glog.

Hi @sergiud @toddlipcon Since the ticket is closed, did we add Asynchronous/double-buffering support in glog ? It doesn't appear so, but can you please confirm.

from glog.

No support was added. The issue was closed due to inactivity. I'll reopen it.

from glog.