Comments (3)
[Condensed from discussion on a different bug tracker.]
dborowitz:
> I don't think prettify.js supports [deep linking to line number fragments]
sop:
It doesn't, that is why we don't have this feature. I wanted to add it
but it wasn't easy, so I punted. :-)
dborowitz:
> so we'd either need to add it upstream or switch our prettification engine. We might
be able to hack in some <a> tags in the output we throw in the <pre>, but I don't know
how that will interact with prettify.
sop:
Uhm, you should look at what project hosting does... and not do that.
They run prettify.js, and then run another JavaScript that
post-processes the pretty.js output in order to reformat the HTML to
get anchors at each line, and reformat the whole thing into a table.
Actually this is similar to what Gerrit Code Review does too, but I
think the way Gerrit does this is only slightly less hacky. We don't
rely on a timer polling the window to see when prettify.js is done,
and then run twice.
I was leaning towards switching to Jgments and doing the formatting at
the server side, but [our internal] build is broken.... Formatting on the server side
will also bloat the response side significantly, but its what all of
the cool kids do (GitHub, ...).
Someone pointed out another JavaScript based formatter recently, but
it doesn't look to be nearly as pluggable as prettify.js is. It only
applies on <pre> blocks already in the DOM like prettify, you can't
call it and steal its output the way Gerrit does.
Reported by None
on 2012-11-11 15:28:25
from gitiles.
Comment deleted
Reported by None
on 2014-07-15 12:58:22
from gitiles.
https://gerrit-review.googlesource.com/56453
Reported by None
on 2014-07-15 13:02:41
from gitiles.
Related Issues (20)
- markdown TOC renderer should also include at least H4-level items
- Symlink viewer renders broken link to destination
- Build impossible on Mac M1 / arm. Please upgrade bazel version HOT 1
- Gerrit cannot be returned properly after browsing code through the Gitiles plugin in Gerrit HOT 1
- Building with bazel fails with `reason: '<>' with anonymous inner classes is not supported in -source 8`
- C++14 single quote (') digit separators aren't rendered correctly in header files
- #./tools/maven/mvn.sh deploy
- https://android.googlesource.com/ the json format error HOT 3
- Add 'y' shortcut to generate permalink to commit HOT 1
- Render graph using mermaid.js in .md files HOT 1
- Unc0ver-volvo
- https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ni HOT 1
- ok
- Ciris
- gitlies
- git clone https://gerrit.googlesource.com/gitiles HOT 1
- We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA ([login here](https://cla.developers.google.com/) to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
- Menuka Vishal
- Código de seguridad de WhatsApp de system company in master data (+52 221 199 1681)
- `text and `json` formats for a tag does not work correctly.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitiles.