Code Monkey home page Code Monkey logo

Comments (2)

spearce avatar spearce commented on May 17, 2024
in this page you can see two timestamps:
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2b6e489fb5bbab066c8dd55167dc40d790c91bab

but there's no information to indicate what timezones those are in.  the reasonable
thing would be to assume they're localized, but we have way too many bad systems at
Google that blindly output PST or are otherwise local to the system/office.  adding
the explicit timezone (or the UTC offset) would make the output unambiguous & reliable
all the time.  all other git viewers i've used include this.

issue 5 covered normalizing the timestamps from various sources to one timezone which
is fine, but the final timezone should not be stripped.  collapsing them in the blame
output so as to get more content in the output is easy to do, but that's still unrelated
to displaying the timestamp in the log output (as quoted above).

Reported by None on 2014-05-14 12:39:24

from gitiles.

spearce avatar spearce commented on May 17, 2024
Thanks for explicitly listing the separate concerns here.

I was actually interpreting the primary anti-timezone argument of issue 5 as "timezone
does not add any information [for Chrome], therefore it should be omitted." The "also
it's taking up valuable horizontal real estate" argument I thought was secondary. I
may have been weighting these incorrectly.

I think we can strip the timezone in blame only but not elsewhere. (Though if I get
pushback from the same people as issue 5 understand that it might not land :)

Reported by None on 2014-05-14 13:34:09

from gitiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.