Code Monkey home page Code Monkey logo

Comments (6)

benderTheCrime avatar benderTheCrime commented on August 30, 2024

I'm not exactly sure if this is related because I don't fully understand the extent of the above comment, but the latest version of this package uses eslint-config-xo@^0.10.1, which does not cover [email protected] version (eslint-config-xo@^0.10.1) does indeed have rules deprecated in eslint@^2.0.0, such as "no-empty-labels".

from eslint-config-google.

calvinkarundu avatar calvinkarundu commented on August 30, 2024

The inclusion of the deprecated rules is what I was pointing out. I'm forced to overwrite those rules after extending the google config so as to stop the linter from throwing errors. If you're aware though, that's fine; I just found it a bit redundant to disable deprecated rules when they shouldn't be there in the first place.

from eslint-config-google.

benderTheCrime avatar benderTheCrime commented on August 30, 2024

Ok, yeah I did the same thing. Nevertheless annoying to have to balloon out my own config file to account for deprecated rules.

👍

from eslint-config-google.

addyosmani avatar addyosmani commented on August 30, 2024

I agree we should probably clean this up. PR welcome if we need this sooner otherwise we'll try tackling this later on the week.

from eslint-config-google.

sindresorhus avatar sindresorhus commented on August 30, 2024

All the ESLint 2 changes was part of [email protected] (which this package depends on), so I have no idea what's requested here.

from eslint-config-google.

calvinkarundu avatar calvinkarundu commented on August 30, 2024

My package.json read "eslint-config-google": "^0.3.0" and not "^0.4.0". Bumped up the version number and everything looks good 👍

from eslint-config-google.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.