Comments (4)
Thanks, I actually don't remember now why that rule wasn't set.
On initial read, it seems like it should be set to:
'keyword-spacing': 2, // defaults to {before: true, after: true}
Does that look right to you?
from eslint-config-google.
Can you please elaborate, and be specific?
from eslint-config-google.
Hello @philipwalton. I wanted to point out there's disabled rule keyword-spacing
which
enforce consistent spacing before and after keywords
in line 202 whereas, in style guide we read
Use of horizontal whitespace depends on location, and falls into three broad categories: leading (at the start of a line), trailing (at the end of a line), and internal. Leading whitespace (i.e., indentation) is addressed elsewhere. Trailing whitespace is forbidden.
Beyond where required by the language or other style rules, and apart from literals, comments, and JSDoc, a single internal ASCII space also appears in the following places only.
- Separating any reserved word (such as
if
,for
, orcatch
) from an open parenthesis ((
) that follows it on that line- ...
Therefore I could write like:
if(condition){
// ...
}
it won't be pointed by linter but according to style guide it's not correct. I catch this particular case but I think there might be more.
from eslint-config-google.
Sorry, I forgot to do this. Fixed via e24704c. I'll cut a new version shortly.
from eslint-config-google.
Related Issues (20)
- Strongly Recommend Extending 'eslint:recommended' HOT 1
- show error using es6 HOT 1
- are tabs allowed? HOT 2
- Throwing Cannot read property 'range' of null HOT 2
- More prominent note that this is for the ES6 style guide? HOT 1
- [error] Definition for rule 'switch-colon-spacing' was not found HOT 3
- prefer-const should be enabled? HOT 1
- Using const variable declaration shows as invalid HOT 3
- Destructuring variable declarations: continuation cannot be more than +2 spaces HOT 3
- Does this config support for eslint 6.1.0 (lastest version)? HOT 2
- ESLint with Google style warning on properly formatted code HOT 5
- Make it compatible with typescript-eslint HOT 5
- [Question] Why is "ConditionalExpression" ignored in the "indent" config? HOT 2
- ESLint v6+: eslint:recommended removed rule 'no-console'
- Plan for replacing valid-jsdoc and require-jsdoc
- Support ESLint 8.x
- Missing rule to ensure file extension in module imports
- Rule 3.4.2.3 Mutability of exports HOT 1
- chore - replace travis CI
- Support ESLint v9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-config-google.