Comments (4)
otherwise I think this issue could probably be closed?
I think so too. 🙃
from dagger.
Dagger tries to find if the Generated annotation is on the class path and then outputs that if it is there, so there is probably some change there between the upgrading the versions that made it visible to the us?
https://github.com/google/dagger/blob/master/java/dagger/internal/codegen/base/SourceFileGenerator.java#L81 which uses https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspProcessingEnv.kt;l=173;drc=067ed409b9bc2dcc59b93c8e9ab8d092beeff3a5 (That's the KSP version. There's something similar for javac, but it is easier to see in the KSP version).
The fix is easy (add java.compiler to the module-info.java)
I'm not really that familiar with how the module-info.java
stuff works, but is that a fix needed in Dagger?
from dagger.
Dagger tries to find if the Generated annotation is on the class path and then outputs that if it is there
Does that mean the generated annotation was not present on the classpath before and now it is? I searched the web a little more and it might be related to the fact, that dagger uses https://github.com/google/auto, which uses guava in turn. By updateing to the latest guava, there might have a been difference classpath order. Also found https://stackoverflow.com/a/53187201, which explains a little the annotation search and #1449 which might be related.
I'm not really that familiar with how the module-info.java stuff works, but is that a fix needed in Dagger?
My bad, this is not a fix in Dagger, this fix applies to an affected project. 😅 I updated the my opening comment.
from dagger.
Does that mean the generated annotation was not present on the classpath before and now it is?
Yup I think so.
My bad, this is not a fix in Dagger, this fix applies to an affected project. 😅 I updated the my opening comment.
Ah cool, thanks! Let me know if there's anything needed then in Dagger, otherwise I think this issue could probably be closed?
from dagger.
Related Issues (20)
- error when ksp.useKSP2=true HOT 2
- Suppress annotation on @Inject is not honored on the Factory HOT 1
- [KSP2] Dagger and Hilt incompatibility with KSP2 HOT 4
- [KSP2] NullPointerException: null cannot be cast to non-null type androidx.room.compiler.processing.XType HOT 1
- App crashing with NPE for some classes when Lazy Class Key is used HOT 7
- OutOfMemoryError with Maven HOT 1
- DaggerAppComponent not creating in the version 2.51.1 HOT 3
- java.lang.ClassNotFoundException: dagger.spi.shaded.androidx.room.compiler.processing.javac.JavacBasicAnnotationProcessor. Hilt 2.49+ HOT 1
- how to manually generate module HOT 1
- Explain how to add dagger jar files manually to the android project HOT 2
- Annotate interface with default Bind implementation HOT 2
- Transitive vulnerability from symbol-processing-api HOT 1
- java.lang.IllegalArgumentException: CreationExtras must have a value by `SAVED_STATE_REGISTRY_OWNER_KEY` HOT 4
- Compile time error with KSP with Generics HOT 4
- java.lang.IllegalArgumentException: Multiple entries with same key HOT 3
- Execution failed for task ':app:kaptDebugKotlin'. > A failure occurred while executing org.jetbrains.kotlin.gradle.internal.KaptWithoutKotlincTask$KaptExecutionWorkAction > java.lang.reflect.InvocationTargetException (no error message) HOT 1
- Stackoverflow when exposing parents of Subcomponents HOT 7
- Hilt not working with android testFixtures? HOT 2
- Hilt 2.44.2 - Class not found when use @AndroidEntryPoint at WidgetReceiver HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dagger.